Split dynamic shape parsing update
#3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3034 +/- ##
===========================================
+ Coverage 91.92% 91.94% +0.01%
===========================================
Files 489 489
Lines 19275 19309 +34
===========================================
+ Hits 17719 17753 +34
Misses 1556 1556 ☔ View full report in Codecov by Sentry. |
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
CharlieL7
requested review from
lakhinderwalia and
umangyadav
and removed request for
TedThemistokleous
lakhinderwalia
approved these changes
May 21, 2024
|
Dont forget to fix the format issue |
umangyadav
reviewed
May 30, 2024
umangyadav
approved these changes
May 31, 2024
umangyadav
reviewed
May 31, 2024
Comment on lines
+181
to
+183
| auto split_axis_is_fixed = [&]() { | ||
| return input_shape.dyn_dims().at(tuned_axis).is_fixed(); | ||
| }; |
There was a problem hiding this comment.
this can simply be a bool variable.
umangyadav
reviewed
May 31, 2024
Comment on lines
+135
to
+136
| vec_splits.resize(num_outputs - 1, chunk_size); | ||
| vec_splits.push_back(last_chunk_size); |
There was a problem hiding this comment.
This can potentially lead to resizing and memory allocation twice for the vector. Ideally, you can allocate vector for the splits once for the size (num_outputs) and then put values in that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitONNX operator to support dynamic shapessplitattribute or input